-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oriented_envelope divide by zero warning when applied to an axes-aligned rectangle #1235
Comments
Until recently (#1228), The algorithm in question is mostly in https://github.com/libgeos/geos/blob/main/src/algorithm/MinimumAreaRectangle.cpp which doesn't show any obvious source of division. Note that pin-pointing the exact place where a FPE occurs can be time-consuming, as I don't know how to register a trace. |
Indeed this does show a FPE in
Now, how to find out where that's occurring... |
If I had to guess I'd say it's somewhere in the convex hull stuff that is invoked? But I am not even not an expert on C++ or GEOS, so I'll leave figuring out where it's happening to the experts! |
Reporting this here so it doesn't fall between the cracks.
I found this on shapely (see shapely/shapely#2215) where it shows up as a warning calling
minimum_rotated_rectangle
on a rectangle parallel to the axes. As reported there:Apparently it's an Apple Silicon problem only. It's only a warning, and the reported result appears correct. So not urgent, but kind of annoying!
I thought I'd see if it was happening on the CLI using
geosop
but that became a bit of a rabbit hole. I assume the function in question isminAreaRectangle
. In any case it doesn't run into the problem at the command line:Which is curious...
The text was updated successfully, but these errors were encountered: