Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build on Apple Silicon Mac #5

Open
diogeneshamilton opened this issue Jan 24, 2024 · 2 comments
Open

Doesn't build on Apple Silicon Mac #5

diogeneshamilton opened this issue Jan 24, 2024 · 2 comments

Comments

@diogeneshamilton
Copy link

diogeneshamilton commented Jan 24, 2024

Not sure if this repo is maintained anymore, I tried seeing if I could fix, but just reporting here that it does not seem to build on Mac arm64. Probably related to discordjs/opus#98, getting this error:

gyp info spawn make gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ] CC(target) Release/obj.target/libogg/deps/libogg/src/framing.o CC(target) Release/obj.target/libogg/deps/libogg/src/bitwise.o LIBTOOL-STATIC Release/ogg.a CC(target) Release/obj.target/libopus/deps/libopus/src/opus_multistream.o ../deps/libopus/src/opus_multistream.c:29:10: fatal error: 'config.h' file not found #include "config.h" ^~~~~~~~~~

I was able to copy over the config.h file from @discordjs/opus, but still got this error:

In file included from ../deps/libopus/silk/SigProc_FIX.h:51: ../deps/libopus/silk/arm/biquad_alt_arm.h:31:11: fatal error: 'celt/arm/armcpu.h' file not found # include "celt/arm/armcpu.h" ^~~~~~~~~~~~~~~~~~~

@dioris-moreno
Copy link
Contributor

Hi @diogeneshamilton,

@jbaudanza reports a similar issue and he solved it by adding the following settings to binding.gyp:

"conditions": [ ['OS=="mac"', { "xcode_settings": { "GCC_ENABLE_CPP_EXCEPTIONS": "YES" } }] ],

These settings were added on version v1.0.13.

I'm a PC guy and I can't reproduce the issue you are reporting.

Please open a PR if you find a solution.

@diogeneshamilton
Copy link
Author

Thanks! Yeah I am using that version which has that change already, but does not seem to resolve. I will report back if I get it fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants