Skip to content

Commit af2a4ba

Browse files
test:
1. Setting isNullValue field will improve the entry size and 2. The default value of isNullValue is set to true will make the break changes for some usages.
1 parent d35dae4 commit af2a4ba

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1095,7 +1095,7 @@ public void testGetBacklogSizeByMessageId() throws Exception {
10951095
completableFuture.get();
10961096
Assert.assertEquals(Optional.ofNullable(
10971097
admin.topics().getBacklogSizeByMessageId(topicName + "-partition-0", MessageId.earliest)),
1098-
Optional.of(320L));
1098+
Optional.of(350L));
10991099
}
11001100

11011101
@Test

pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1765,7 +1765,7 @@ public void testCompaction() throws Exception {
17651765
assertEquals(cm.get(0).value, 10);
17661766
cm = (List<Metric>) metrics.get("pulsar_compaction_compacted_entries_size");
17671767
assertEquals(cm.size(), 1);
1768-
assertEquals(cm.get(0).value, 840);
1768+
assertEquals(cm.get(0).value, 870);
17691769

17701770
pulsarClient.close();
17711771
}

pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactionTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1384,7 +1384,7 @@ public void testEmptyPayloadDeletesWhenEncrypted() throws Exception {
13841384

13851385
Message<byte[]> message4 = consumer.receive();
13861386
Assert.assertEquals(message4.getKey(), "key2");
1387-
Assert.assertEquals(new String(message4.getData()), "");
1387+
assertNull(message4.getData());
13881388

13891389
Message<byte[]> message5 = consumer.receive();
13901390
Assert.assertEquals(message5.getKey(), "key4");

0 commit comments

Comments
 (0)