Skip to content

Icon doesn't maintain its position in the ribbon #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geewiz opened this issue Oct 9, 2023 · 5 comments · Fixed by #222
Closed

Icon doesn't maintain its position in the ribbon #200

geewiz opened this issue Oct 9, 2023 · 5 comments · Fixed by #222

Comments

@geewiz
Copy link

geewiz commented Oct 9, 2023

The plugin's icon is currently displayed at the bottom of my sidebar ribbon. When I move the icon within the ribbon and restart Obsidian, it's at the bottom again. Any other icon maintains its position where ever I put it.

I'm using Obsidian 1.4.14 and Periodic Notes 0.0.17.

@lzilioli
Copy link

lzilioli commented Dec 1, 2023

I am experiencing this as well. Very annoying.

@natattack99
Copy link

It also does this if you disable the ribbon from within settings (appearance -> interface -> ribbon menu)

@itsonlyjames
Copy link
Contributor

itsonlyjames commented Jul 17, 2024

Noticed this issue myself too, it's the way the ribbon icon items get added via onLayoutReady and onSettingsChange. They always get appended to the list, rather than being added once, and not changed or reinstated. I'm going to attempt to fix myself because it's super frustrating. If I succeed, I'll let you know.

Worth noting, this issue exists in both mobile and desktop, I only noticed it through the mobile ribbon.

@itsonlyjames
Copy link
Contributor

itsonlyjames commented Jul 17, 2024

You're not gonna believe this... easiest fix ever once I figured it out

I moved two lines of code...

image

Problem solved. Trouble now is, how we get this out to users. This project is seeimngly abandoned and no PR has been merged since 2022... I don't know how to go about this. Obviously for me it's fixed, but for everyone else you'll need to either manually mimic this fix, or we can somehow adopt this plugin so as to provide this fix for the 314,465 other users...

To fix it, go into .obsidian/plugins/periodic-notes/main.js and move the code like in the screenshot.

@flowerornament
Copy link

Looks like this was merged, but I'm currently having this issue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants