[Feature] Add support ignoring parent node_modules for monorepos?

[MaxmaxmaximusGitHub]

Add support ignoring parent node_modules for monorepos?

[MaxmaxmaximusGitHub]

like this

utils.js:

exports.getModulesNamesFromDirLocal = function getModulesNamesFromDirLocal(dir) {
  return exports.readDir(path.resolve(dir, './node_modules')).filter(x => {
    return !exports.contains(['.bin'], x)
  })
}


exports.getModulesNamesFromDir = function getModulesNamesFromDir(dir) {
  const allFoundModules = []
  const pathParts = dir.split(path.sep)

  for (let i = pathParts.length - 1; i >= 0; i--) {
    const parentDirs = pathParts.slice(0, i)
    const parentPath = parentDirs.join(path.sep)
    const foundModules = exports.getModulesNamesFromDirLocal(parentPath)
    allFoundModules.push(...foundModules)
  }

  return allFoundModules
}

[liady]

In version 2 you can pass additionalModuleDirs to options. Do you think this functionality (looking up the tree) is still needed?

[MaxmaxmaximusGitHub]

@liady this functionality should work by default since node_modules has tree-floating semantics.

[aprilandjan]

@liady Yeah this is definitely needed when using yarn workspace or lerna, it will be good if it matches with current module resolving strategies.

[akomm]

In version 2 you can pass additionalModuleDirs to options. Do you think this functionality (looking up the tree) is still needed?

Yes its needed. Why should a package explicitly point to a directory, which is out of responsibility of this package? (node_modules in monorepo root for example).

[Kadeluxe]

Maybe it could be an option such as scanParents or something like this. Although personally I'm OK with additionalModuleDirs because in my monorepo projects I have project-specific build setups anyway.