Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Security, Public Safety and Privacy Concerns #22

Open
neildmd opened this issue Jan 8, 2023 · 4 comments
Open

Major Security, Public Safety and Privacy Concerns #22

neildmd opened this issue Jan 8, 2023 · 4 comments

Comments

@neildmd
Copy link

neildmd commented Jan 8, 2023

The way this extension currently works, when someone clicks the Share Link or Download PDF buttons the full conversation log is uploaded to an Amazon S3 container and set to public. This all happens through a function hosted at https://chat-gpt-static.netlify.app/.netlify/functions/chatgpt-upload which we are unable to see the code for.

In addition to the above, the way this function is referenced is through a text file also hosted on Amazon S3. The owner of the chatgpt-static S3 container on AWS could change the contents of the url.txt file (https://chatgpt-static.s3.amazonaws.com/url.txt) at any time to include a malicious script, which poses another serious security issue, on top of the one above.

Further, since the full conversation log is uploaded to an S3 container and set to public, with no way for us to delete the data. If someone happens to have some personal or other potentially harmful information in the conversation log being uploaded, then that poses a serious public safety issue on top of the security issue.

I would highly recommend you come up with a more direct and local way to achieve the same goals in light of the major issues above.

@Manamama
Copy link

Manamama commented Jan 9, 2023

See also my same comment here, with more details on the actual code that is (not) visible to us.

@neildmd
Copy link
Author

neildmd commented Jan 9, 2023

@Manamama I've found the code that's running inside the Netlify function under the same developer here: https://github.com/liady/chatgpt-static/blob/main/netlify/functions/chatgpt-upload/chatgpt-upload.js

The code is harmless but we still don't know if this is the exact code running on Netlify and the function called inside the url.txt file could still be changed at any time by the owner. That being said, it's obvious to me that the developer has no malicious intentions, just look at all the other projects they've uploaded here on github.

The main concern is this: If @liady github login or his personal computer ever become compromised then the attacker could potentially replace the function inside of url.txt with their own malicious code.

@Manamama
Copy link

Manamama commented Jan 9, 2023

Thanks for the legwork - my i-flowers sent to you above.

@neildmd
That being said, it's obvious to me that the developer has no malicious intentions,

And I have never claimed otherwise.
Yet:

just look at all the other projects they've uploaded here on github.

Just look: (in)security by affinity (our) mindtrick: here among us, the anonymous Githubers.
(Plus a random IT Sec series of academic papers about the same, granted: very controversial.)

The main concern is this: If @liady github login or his personal computer ever become compromised...

or if he, his brother, or his (lol)cat decide to turn to a black hat hacker...

then the attacke[r]* could potentially replace the function inside of url.txt with their own malicious code.

And here we all agree in full.

(*) "Attacker", I presume

@neildmd
Copy link
Author

neildmd commented Jan 10, 2023

@Manamama Yes I feel your concerns. I'm not using this unless the netlify code is moved to local.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants