Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in the password results in no password being sent to SonarTfsAnnotate.exe #74

Open
artisan-jimmy opened this issue Aug 18, 2023 · 1 comment

Comments

@artisan-jimmy
Copy link

I've noticed that having special characters causes the password to be sent as an empty string to SonarTfsAnnotate.exe.
The password I've tested with contains the following special characters: #, ? and (
Not sure what character is the culprit, but I've verified this by modifying the SonarTfsAnnotate.exe by adding the following:

using (var sw = new StreamWriter("C:\\temp\\scm-tfvc.log", true))
{
    sw.WriteLine($"un: [{username}]");
    sw.WriteLine($"pw: [{password}]");
    sw.Flush();
}
@lg2de
Copy link
Owner

lg2de commented Dec 7, 2023

I've no idea why the mentioned characters may cause the described behavior.
I myself do not recommend to use username and password. Please use PAT instead for security reasons. (The feature was implemented before I took ownership for this repo.)

So, if I invest time in this issue I would remove support for username/password.
You are welcome to start more detailed analysis. A pull request is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants