Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Failures with rebar3 3.23.0 #488

Closed
VlkrS opened this issue Apr 15, 2024 · 4 comments
Closed

Test Failures with rebar3 3.23.0 #488

VlkrS opened this issue Apr 15, 2024 · 4 comments

Comments

@VlkrS
Copy link

VlkrS commented Apr 15, 2024

With rebar3 3.23.0, the following tests fail for lfe 2.1.4:

===> Testing prop_lfe_docs:prop_define_lambda()
Error: Unrecognized option: {task,[50,48,44,99,116]}.
===> Testing prop_lfe_docs:prop_define_match()
Error: Unrecognized option: {task,[50,48,44,99,116]}.
===>
0/2 properties passed, 2 failed
===> Failed test cases:
prop_lfe_docs:prop_define_lambda() -> {error,
                                       {unrecognized_option,{task,"20,ct"}}}
prop_lfe_docs:prop_define_match() -> {error,
                                      {unrecognized_option,{task,"20,ct"}}}

Both tests pass when using rebar3 3.22.1.

@VlkrS
Copy link
Author

VlkrS commented May 28, 2024

The problem is in the Makefile in

lfe/Makefile

Line 199 in b54a121

@rebar3 as test do compile,eunit,eunit,proper -n 20,ct

Reordering this as

@rebar3 as test do compile,eunit,eunit,ct,proper -n 20

makes all tests pass again.

@delitrem
Copy link
Contributor

delitrem commented Jul 1, 2024

Oops. I'm very sorry, have noticed this bugreport only after PR submission (#491). I can cancel it or do whatever more appricated.

BTW, it seems to be related to: erlang/rebar3#2813.

@VlkrS
Copy link
Author

VlkrS commented Jul 1, 2024

Not sure if this is addressed to me, but in case it is: I'm happy with any kind of fix.

@oubiwann
Copy link
Member

oubiwann commented Aug 3, 2024

Thanks, @delitrem! (both for the PR and for your comments here, including the link to the breaking change in rebar3).

@oubiwann oubiwann closed this as completed Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants