SNS governance canister, show each neuron reward portion of the reward events. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levifeldman
force-pushed
the
levifeldman-show-neuron-reward-portion
branch
from
35ceaaa
to
c716883
Compare
levifeldman
force-pushed
the
levifeldman-show-neuron-reward-portion
branch
2 times, most recently
from
5220679
to
3d88e2c
Compare
…tion of the latest 5 reward events.
levifeldman
force-pushed
the
levifeldman-show-neuron-reward-portion
branch
from
3d88e2c
to
f480f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets SNSs share the revenue of the SNS that is generated through the dapp with the SNS neuron-holders proportional to the voting participation of the neuron holders. This is implemented by saving the neuron_reward_e8s of the latest 5 reward-events in each Neuron. This way, a SNS can call
list_neuronsand view the portion of a reward-event given to each neuron.The neuron_reward_e8s are saved on each neuron with the corresponding reward-event timestamp (reward_event_end_timestamp_seconds) so that when calling list_neurons over many chunks, the caller can correlate reward-events of the different neurons even if a reward-event is being added to the neurons in between the different list_neuron calls (the chunks of the list_neurons calls).