Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightbox close button #1

Open
hudat opened this issue Dec 15, 2014 · 5 comments
Open

lightbox close button #1

hudat opened this issue Dec 15, 2014 · 5 comments

Comments

@hudat
Copy link

hudat commented Dec 15, 2014

Tapping on the lightbox's close button sends user to hyperlink associated with image. Instead, it should close the lightbox and keep user on the same page.

@leventebalogh
Copy link
Owner

Exactly, however i didn't experience this kind of behaviour. Can you show me an example? Or we can try to find the solution in private message, too: [email protected]

@thearabbit
Copy link

I have the same problem.
It should have the close btn on lightbox, when we click close btn it keep user on the old page.

@thearabbit
Copy link

I try to add target="_blank", lightbox show the close btn.
But don't show the image, and close btn don't work.

@patrickml
Copy link

I think the real issue is the event is stopped when the close button is clicked

https://github.com/leventebalogh/horka-swipebox/blob/master/swipebox/js/jquery.swipebox.js#L583

Instead the lightbox closes and the event continues and clicks what ever is behind the close button and lightbox. I am only experiencing this on mobile tho.

@daorren
Copy link

daorren commented Feb 28, 2017

Well, target="_blank" works for me!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants