Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3] Rework jwa algorithms #1202

Closed
lestrrat opened this issue Oct 4, 2024 · 1 comment
Closed

[v3] Rework jwa algorithms #1202

lestrrat opened this issue Oct 4, 2024 · 1 comment
Assignees
@lestrrat
Labels
long-term

Comments

@lestrrat
Copy link
Collaborator

lestrrat commented Oct 4, 2024

  • Use objects, not strings
    • Add metadata like Symmetric in the object
  • Use functions to obtain values instead of constants
@lestrrat
Copy link
Collaborator Author

lestrrat commented Oct 6, 2024

fixed by #1203

@lestrrat lestrrat closed this as completed Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lestrrat lestrrat

Labels
long-term
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lestrrat