Validate everything but expiration

[tonsV2]

I'm trying to parse a HTTP request which might contain an expired token. Even if the token is expired I'd still like to ensure everything else validates and parse the payload. (It's for logging users out and ensuring some cookies are deleted client side.)

I'm trying to do the following

token, err := jwt.ParseRequest(
	request,
	jwt.WithKey(jwa.RS256, h.publicKey),
	jwt.WithHeaderKey("Authorization"),
	jwt.WithCookieKey("accessToken"),
	jwt.WithCookieKey("refreshToken"),
	jwt.WithTypedClaim("user", model.User{}),
)
//	if err != nil && !errors.Is(err, jwt.ErrTokenExpired()) { // This doesn't work
if err != nil && !strings.Contains(err.Error(), "error: \"\\\"exp\\\" not satisfied") { // This also doesn't work because if the token is expired and invalid we'll move on
	return nil, err
}

userData, ok := token.Get("user")
if !ok {
	return nil, errors.New("user not found in claims")
}

But if the token is expired, then token.Get("user") results in panic. I could parse the request twice and do some hacky error handling but I was hoping there was a better way.

[lestrrat]

But if the token is expired, then token.Get("user") results in panic.

Yes, because token is nil.

// if err != nil && !errors.Is(err, jwt.ErrTokenExpired()) { // This doesn't work

Please provide more details. I can't debug unless I have a reproducible test case.

---

To do what you want, you should delay validation by calling a Parse with WithValidation(false):

token, err := jwt.ParseRequest(
	request,
	jwt.WithValidate(false),  // **THIS**
	// other options....
)

This will give you a un-validated (but verified) token. Then you can run validation manually:

err := jwt.Validate(token, .... options....)

This way token is not nil, and you should be able to look into its contents

[tonsV2]

This is how I now parse and validate.
These are my tests related to signing out and this one specifically submits an expired token.

Everything seems to work for my use case but I'm a bit surprised about the following. Maybe it is the expected behavior but it might be a bug, I'll let you decide :-)

token, err := jwt.ParseRequest(
	request,
	jwt.WithKey(jwa.RS256, h.publicKey),
	jwt.WithHeaderKey("Authorization"),
	jwt.WithCookieKey("accessToken"),
	jwt.WithCookieKey("refreshToken"),
	jwt.WithTypedClaim("user", model.User{}),
	//		jwt.WithValidate(false),
)
if err != nil && errors.Is(err, jwt.ErrTokenExpired()) {
	log.Println("expired token")
}

With the above code, and the request carrying an expired token, I would expect the log statement to be reached. I do get an error with the below text

failed to find a valid token in any location of the request (tried: [header keys: "Authorization"]). Additionally, errors were encountered during attempts to parse headers: ([header key: "Authorization", error: "\"exp\" not satisfied"]) cookies: ([cookie key: "accessToken", error: "http: named cookie not present"], [cookie key: "refreshToken", error: "http: named cookie not present"]

But it doesn't seem to be an errTokenExpired error.

[lestrrat]

@tonsV2 I couldn't immediately find where you set the "exp" field on the JWT. Are you by any chance trying to ask this library to tell you that the COOKIE has expired? If that's the case, this library isn't going to catch that.

[github-actions]

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[tonsV2]

Sorry for the late reply.

No, this isn't about the cookie expiration. I'm surprised that with an expired token the error message does contain ""exp" not satisfied" however the actual error doesn't seem to be a errTokenExpired. So the if statement in the example code I include in my post doesn't evaluate to true. Specifically errors.Is(err, jwt.ErrTokenExpired()) isn't true despite the token being expired.

[lestrrat]

@tonsV2 Sorry, I admit I haven't dug deep into the test code, but from the links you gave me I can't find the token contents. Can you please show me exactly what the tokens contain that should error with token expired?

[github-actions]

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity. This does not mean your issue is rejected, but rather it is done to hide it from the view of the maintains for the time being. Feel free to reopen if you have new comments