Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.10: Breaks IE Compat Option #3446

Closed
bdkjones opened this issue Oct 22, 2019 · 4 comments · May be fixed by PGP-or-D1E/openlibrary#6
Closed

3.10: Breaks IE Compat Option #3446

bdkjones opened this issue Oct 22, 2019 · 4 comments · May be fixed by PGP-or-D1E/openlibrary#6

Comments

@bdkjones
Copy link

If I pass --ie-compat to lessc using 3.10.3, I now get this error:

Unable to load plugin ie-compat please make sure that it is installed under or at the same level as less

As far as I can tell, you did not factor the IE Compatibility option out to a separate plugin (no reference in Changelog and I can't find any such plugin online). The --ie-compat option still appears when running lessc -h.

Please advise. Has this functionality been silently removed?

@matthew-dean
Copy link
Member

@bdkjones 🤔 You're correct that while this is deprecated for a long time (as it only applies to the long-defunct IE8), it wasn't intended to be intentionally removed without a proper semver major version bump. This was probably a refactoring oversight.

@matthew-dean
Copy link
Member

@bdkjones Note that the only appropriate fix would be to essentially silently do nothing, instead of throwing an error, as IE8 isn't supported as a browser version in 3.0+, even if the option should still be present.

@bdkjones
Copy link
Author

I figured it was something like this. I’ve silently disabled the option in my app and will remove the option from the UI entirely in the next release. I’d recommend, at the very least, removing the description from the “help” printout and documentation so folks don’t pass the option. Doing that (and fixing this issue so the flag does nothing when passed, but does not error) would not be a breaking change.

@matthew-dean
Copy link
Member

@bdkjones Agreed. It definitely wasn't intentional. It should be trivial to add the silent option to an upcoming release, if I can find the time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants