fix(import): Handle filepaths with spaces more robustly

[chrisdothtml]

CC @evocateur

Fixes #432

Description

Update replace pattern when rewriting commit history to support files with spaces in them. Still has some edge cases where this issue will happen (see this comment)

How Has This Been Tested?

Ran my new test before and after the pattern update. Confirmed it failed before, and passes after. Also have confirmed this fix works on a repo of my own

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[chrisdothtml]

@evocateur I am interested in trying something with custom prefix options, but figured I'd get this fix pushed at the very least.

What pattern would you suggest instead of a/ and b/? Maybe something crazy explicit like COMPARE_FILE_A/ and COMPARE_FILE_B/?

Also, side note: is it normal to be getting a ton of linting errors? Not even related to anything I did, getting them on the latest master branch. Also, it probably should be mentioned in the CONTRIBUTING doc that you need lerna globally installed for tests to run (or I needed to at least)

EDIT: Any idea what's going on with this test?

[chrisdothtml]

I've added the custom prefixes, and improved my test for this a bit (so now all cases are resolved for filepaths with spaces). The tests are all passing for me locally and I'm unable to tell what's causing them to fail in the CI. May just need to be restarted.

Let me know if there's anything else you need from me in this PR

[evocateur]

Looks great, thanks!

[evocateur]

The AppVeyor build is failing in master because apparently quoted shell arguments are hard for Windows, not your fault. I restarted the Travis builds, looks like they hit a cascade of timeouts for environmental reasons.

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.