Fix 404 deletion #878
Merged
Fix 404 deletion #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… returns 404, we delete '/post/index.html'. Before, we wouldn't delete '/post' because it's a directory.
john-shaffer
force-pushed
the
fix-404-deletion
branch
from
a899f53 to
bb4f605
Compare
john-shaffer
referenced
this pull request
Aug 19, 2022
2f7c2cc changed detectURLs to only return the URLs, not enqueue them. This means that the detect case here was basically a no-op, other than printing a very misleading log message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.