-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[regression] Guzzle is ignoring your 'verify' => false #785
Comments
Aww, bummer. PHP Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 49152 bytes) in
/Volumes/Bigbish/webdev/drugs/app/public/wp-content/plugins/wp2static/vendor/leonstafford/wp2staticpsr7/src/Stream.php
on line 95 Also it looks like the incomplete output is lacking a bunch of plugin output and the theme seems to have reverted to defaults where it is displaying some random menu that does not exist in the database, and so on. Not quite sure what to make of it. Still, this is absolutely going the right direction. Good job, and keep it up! |
Hey @working-name, thanks for reporting these! Yeah, there's no elegant job termination currently, so you'll likely have a bunch of crawl tasks still trying even when a network timeout signals to UI that it's errored. Pump up your PHP memory_limit setting and let it do its thing again, hopefully it completes! I'll sort this Guzzle issue one way or another. Recently went back to Guzzle, due to ease of PHP 8 code quality checks and future asynchronous crawling ideas, but, we'll see the state of things next time I sit down to code. I suggest simply having no TLS if possible, to mitigate all the cert stuff and squeeze out a bit more performance from your dev server. If you haven't tried yet, you may like https://lokl.dev. Sounds like you're on a macOS and that works pretty smoothly. Cheers, Leon |
It looks like we actually missed out a place where we should have set 'verify' false. @working-name Can you confirm if 2390344 fixes this for you, or does the issue remain? |
Hi there,
Finally got around to playing with this awesome little thing. I ended up hardcoding the value to false inside guzzler's files. Stubborn stuff, most of the time the function was called the option was blank, and when it was set, its value was
1
.Anyway, if there's anything I can provide to help you debug this, let me know.
Environment details:
Unrelated: I wonder if there's a way to poll progress rather than start a request and keep it active. I got a 504 after a while, but wp2static is still going - I added error_log to catch that
'verify'
thang. For a huge site with 10-20k links I'm sure it'll take forever. 🤣Awesome stuff though, can't wait to see what it outputs.
The text was updated successfully, but these errors were encountered: