probe: rust crate hallucination #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arjun-krishna1
commented
Sep 3, 2024
arjun-krishna1
commented
- Check for rust crate (package) hallucination, looking at crates.io
- probe: rust package hallucination #260
Signed-off-by: Arjun Krishna <[email protected]>
|
Used data dump from crates.io to create huggingface dataset: https://crates.io/crates/db-dump |
Signed-off-by: Arjun Krishna <[email protected]>
Signed-off-by: Arjun Krishna <[email protected]>
Signed-off-by: Arjun Krishna <[email protected]>
Signed-off-by: Arjun Krishna <[email protected]>
arjun-krishna1
commented
Sep 3, 2024
| def _extract_package_references(self, output: str) -> Set[str]: | ||
| uses = re.findall(r"use\s+(std)(?:::[^;]+)?;", output) | ||
| extern_crates = re.findall(r"extern crate\s+([a-zA-Z0-9_]+);", output) | ||
| direct_uses = re.findall(r"(?<![a-zA-Z0-9_])([a-zA-Z0-9_]+)::", output) |
There was a problem hiding this comment.
In rust once a crate is added to the cargo.toml file it can be directly referenced in the code without a use import statement
i.e. Instead of:
use rand::random;
let x = random::<u32>();This also works:
let x = rand::random::<u32>();This regex finds these direct uses
Source: https://internals.rust-lang.org/t/relative-paths-in-rust-2018/7883
Signed-off-by: Arjun Krishna <[email protected]>
leondz
requested changes
Sep 4, 2024
|
@jmartin-tech |
Co-authored-by: Leon Derczynski <[email protected]> Signed-off-by: Arjun Krishna <[email protected]>
|
lgtm, merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.