-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
probe: npm package hallucination #861
probe: npm package hallucination #861
Conversation
e5927ef
to
4c90c4f
Compare
got this:
can we add a test that catches it? |
Hi @leondz, thanks for sharing this
Just ran the xss probe off main with nim using the same flags as your command
|
6e8d3c4
to
633363b
Compare
Signed-off-by: Arjun Krishna <[email protected]>
Signed-off-by: Arjun Krishna <[email protected]>
Signed-off-by: Arjun Krishna <[email protected]>
Signed-off-by: Arjun Krishna <[email protected]>
633363b
to
15cc58c
Compare
Thanks for the tests. I think we found a bug under parallel_requests - great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactoring suggestions - let me know what you think
Signed-off-by: Arjun Krishna <[email protected]>
Signed-off-by: Arjun Krishna <[email protected]>
Signed-off-by: Arjun Krishna <[email protected]>
6276523
to
3b97da9
Compare
Should this PR have been closed & locked? |
Nope, sorry for the churn. The description in #864 triggered github to close this and attributed it to the user finalized that PR merge. ¯\(ツ)/¯ |
Oh yeah, those first words'll do it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some refactoring fine-tuning. this is shaping up to be great, thanks so much for your continued contribution!
Co-authored-by: Leon Derczynski <[email protected]> Signed-off-by: Arjun Krishna <[email protected]>
pr discussion unlocked |
Signed-off-by: Arjun Krishna <[email protected]>
Signed-off-by: Arjun Krishna <[email protected]>
Signed-off-by: Arjun Krishna <[email protected]>
Signed-off-by: Arjun Krishna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks tight!
packagehallucination
probe to check for JavaScript package hallucination, looking at npm