Flags for varying NIM seed and temperature every call #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Martin <[email protected]>
jmartin-tech
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Minor change pushed in 2779ede, another idea is also proposed to defer to Configurable pattern a bit more.
Signed-off-by: Jeffrey Martin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIMs tend to always give the same response for a given config. This breaks the method of using
generations > 1for stochastic testing. This PR adds two options to make sure the random seed or temperature are varied every call. Not all existing NIMs respect the values in these fields, so the options are both setTrueby default, to give the best chances ofgenerations > 1working as expected (i.e. generating multiple potentially different responses).