Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial for contributing a generator #688

Merged
merged 8 commits into from
May 17, 2024
Merged

Tutorial for contributing a generator #688

merged 8 commits into from
May 17, 2024

Conversation

leondz
Copy link
Collaborator

@leondz leondz commented May 16, 2024

No description provided.

@leondz leondz added the documentation Improvements or additions to documentation label May 16, 2024
@leondz leondz requested a review from jmartin-tech May 16, 2024 12:06
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walk through hits all the major points, I added a few comments that might need to do some think on and could possibly defer to later iteration on the guide.

docs/source/contributing.generator.rst Show resolved Hide resolved
docs/source/contributing.generator.rst Outdated Show resolved Hide resolved
docs/source/contributing.generator.rst Outdated Show resolved Hide resolved
docs/source/contributing.generator.rst Show resolved Hide resolved
docs/source/contributing.rst Outdated Show resolved Hide resolved
docs/source/contributing.rst Show resolved Hide resolved
leondz and others added 4 commits May 16, 2024 21:02
Co-authored-by: Jeffrey Martin <[email protected]>
Signed-off-by: Leon Derczynski <[email protected]>
Co-authored-by: Jeffrey Martin <[email protected]>
Signed-off-by: Leon Derczynski <[email protected]>
Co-authored-by: Jeffrey Martin <[email protected]>
Signed-off-by: Leon Derczynski <[email protected]>
@leondz leondz merged commit 1e90b32 into main May 17, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
@jmartin-tech jmartin-tech deleted the docs/new_generator branch May 17, 2024 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants