Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make banner line test dynamic #670

Merged
merged 1 commit into from
May 10, 2024

Conversation

jmartin-tech
Copy link
Collaborator

Build the banner string check in a dynamic pattern

This avoids test failures when the application name or description impact the banner message for tests that are filtering the banner.

Build the banner string check in a dynamic pattern

Signed-off-by: Jeffrey Martin <[email protected]>
@jmartin-tech jmartin-tech requested a review from leondz May 10, 2024 13:45
Copy link
Collaborator

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@leondz leondz merged commit 8152472 into NVIDIA:main May 10, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
@jmartin-tech jmartin-tech deleted the fix/dynamic-banner-string branch May 10, 2024 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants