Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Uint64List support from polkadart_scale_codec and polkadart_cli packages #297

Open
Lohann opened this issue Mar 22, 2023 · 2 comments

Comments

@Lohann
Copy link
Collaborator

Lohann commented Mar 22, 2023

Context

Dart Web doesn't support Uint64List, and some packages rely in this data structure, we must remove Uint64List references otherwise polkadart_scale_codec cannot be used on the web. Change all ocurrences to lists of BigInt.

Acceptance Criteria

  • Remove Uint64List and Int64List support from u64 and i64 codecs.
  • Refactor polkadart_cli for not use U64Sequence, I64Sequence, U64Array and I64Array codecs.
  • Unit tests passes
  • Update CHANGELOG.md for both packages.
@Lohann Lohann added the bug label Mar 22, 2023
@justkawal justkawal self-assigned this Mar 23, 2023
@avive
Copy link
Contributor

avive commented Jul 18, 2023

Thank you for this lovely lib! We consider using it for Karma Coin mobile app. Can you guys please confirm that supporting web apps is on the project short-term intention to support web apps and fix this issue?

@Lohann
Copy link
Collaborator Author

Lohann commented Jul 19, 2023

@avive yes! the plan is fully support all platforms supported by flutter, currently the only blocker for web is this issue here, which will be fixed shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants