From 4fbb0b1bc309c0bf6e1c24cb5c69c3fc346e9759 Mon Sep 17 00:00:00 2001 From: Leo Monti <61606076+leomontigatti@users.noreply.github.com> Date: Thu, 22 Oct 2026 21:53:26 -0300 Subject: [PATCH] feat(code-review): Long Function joins the smell baseline Co-Authored-By: Claude Opus 5.5 --- skills/code-review/SKILL.md | 1 + 1 file changed, 1 insertion(+) diff --git a/skills/code-review/SKILL.md b/skills/code-review/SKILL.md index 099d07c..8b88d2c 100644 --- a/skills/code-review/SKILL.md +++ b/skills/code-review/SKILL.md @@ -43,6 +43,7 @@ On top of whatever the repo documents, the Standards axis always carries the **s Each smell reads _what it is_ → _how to fix_; match it against the diff: - **Mysterious Name**: a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky. +- **Long Function**: the happy path is buried under validation and detail. → move each supporting detail into a helper named for a real concept, below the function it serves; a helper with no concept of its own stays inline. - **Duplicated Code**: the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both. - **Feature Envy**: a method that reaches into another object's data more than its own. → move the method onto the data it envies. - **Data Clumps**: the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.