-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiling message-io with just websocket
feature breaks.
#98
Comments
Ouch! This is due to a recent refactorization. I will fix it ASAP! Thanks!! |
As you suggested, this #99 fixes the compilation issue. Regarding your comment, why you say that this change doesn't make sense for the web? Maybe i'm not understanding something |
Websocket seemed to be an implementation of websocket not bindings to web_sys's websocket? |
Sorry, I didn't understand you well. Yes, the message-io implementation is based in tungstenite-rs. which seems to not support wasm. The idea will be to detect the current platform and swap the WebSocket adapter implementation from tungstenite to some other crate as |
I close this issue (since the compilation problem is solved) and open #100 instead to tracking the wasm support |
Error message:
This might be intended, but in that case there should be
websocket = ["tcp"]
. It also doesn't make sense for the web either. Maybe have two differentwebsocket
features?websocket
andwebsocket-web
.The text was updated successfully, but these errors were encountered: