Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify thread name #112

Open
jbabyhacker opened this issue Feb 8, 2022 · 3 comments
Open

Modify thread name #112

jbabyhacker opened this issue Feb 8, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jbabyhacker
Copy link

I would like the ability to provide an alternate thread name for the threads in for_each() and for_each_async(). If this is a change you are open to incorporating, I can make the change and put up a PR. Any interest?

@lemunozm
Copy link
Owner

lemunozm commented Feb 8, 2022

Hi!

I'm open to it :)

How will you enable this functionality without touching the API?

I see some approaches to configure the thread names:

  • compilation variable.
  • environment variable.
  • static variable you set before starting anything message-io related (maybe the most versatile).

@jbabyhacker
Copy link
Author

I was wondering how to do it as well. I think the static variable approach you mentioned would be the best approach.

@lemunozm
Copy link
Owner

lemunozm commented Feb 8, 2022

As a suggestion, the crate https://github.com/matklad/once_cell could be usefull

@lemunozm lemunozm added the enhancement New feature or request label Jul 12, 2022
@lemunozm lemunozm added the good first issue Good for newcomers label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants