Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.0 #39

Merged
merged 14 commits into from
Mar 25, 2019
Merged

2.3.0 #39

merged 14 commits into from
Mar 25, 2019

Conversation

lejard-h
Copy link
Owner

@lejard-h lejard-h commented Mar 24, 2019

  • Breaking Change
    ChopperClient.errorConverter is now taking an ErrorConverter as a parameter

    abstract class ErrorConverter {
      FutureOr<Response> convertError<ResultType, ItemType>(Response response);
    }
  • Remove deprecated Chopper.service<Type>(Type)

  • Add QueryMap annotation (@QueryMap annotation #38)

Fix:

@coveralls
Copy link

coveralls commented Mar 24, 2019

Pull Request Test Coverage Report for Build 62

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+29.06%) to 85.563%

Files with Coverage Reduction New Missed Lines %
lib/src/interceptor.dart 1 98.33%
lib/src/request.dart 3 92.19%
lib/src/base.dart 7 92.08%
lib/src/annotations.dart 23 0.0%
Totals Coverage Status
Change from base Build 53: 29.06%
Covered Lines: 243
Relevant Lines: 284

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@cb512a7). Click here to learn what that means.
The diff coverage is 97.89%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #39   +/-   ##
=========================================
  Coverage          ?   85.56%           
=========================================
  Files             ?        7           
  Lines             ?      284           
  Branches          ?        0           
=========================================
  Hits              ?      243           
  Misses            ?       41           
  Partials          ?        0
Impacted Files Coverage Δ
chopper/lib/src/response.dart 100% <ø> (ø)
chopper/lib/src/annotations.dart 0% <0%> (ø)
chopper/lib/src/request.dart 92.18% <100%> (ø)
chopper/lib/src/base.dart 92.07% <100%> (ø)
chopper/lib/src/io.dart 100% <100%> (ø)
chopper/lib/src/utils.dart 88.88% <100%> (ø)
chopper/lib/src/interceptor.dart 98.33% <94.73%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb512a7...5dad161. Read the comment docs.

@lejard-h lejard-h merged commit 41deb9d into master Mar 25, 2019
@lejard-h lejard-h deleted the improve_converters branch March 25, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants