Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: quick actions submenu flickers every 5s #491

Closed
mjvmroz opened this issue Aug 3, 2022 · 5 comments
Closed

Bug: quick actions submenu flickers every 5s #491

mjvmroz opened this issue Aug 3, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@mjvmroz
Copy link

mjvmroz commented Aug 3, 2022

App version
4.0.6

Installation source

  • AppStore

Describe the bug
The quick actions menu flickers every 5s.

To Reproduce
Steps to reproduce the behavior:

  1. Click on the MeetingBar menu bar item to expand its menu
  2. Hover on "Quick actions" for up to five seconds
  3. Observe the flicker
  4. Hover on any sub-item under "Quick actions" for up to five seconds
  5. Observe that the flicker now causes the menu to close.

Expected behavior
The menu should be stable.

Desktop (please complete the following information):

  • macOS version: 12.4

Additional context
Looks like it's due to updateMenu nuking the whole menu and rebuilding it from scratch. It doesn't seem to cause any issues for top-level items, but can be annoying for submenus if you get unlucky enough to see the flicker when you're traversing that menu, which is reasonably likely given the high frequency.

Since the sub-menu isn't informed by anything updated on a clock, the application could be modified to be more selective and only remove + recreate actual meeting items.

@mjvmroz mjvmroz added the bug Something isn't working label Aug 3, 2022
@dhleong
Copy link

dhleong commented Aug 31, 2022

This happens for mousing over event details as well FWIW.

@leits leits closed this as completed in 9996a9c Oct 16, 2022
@leits
Copy link
Owner

leits commented Oct 16, 2022

Thanks for the report!
Added fix to the next release scope (4.2.).

@leits
Copy link
Owner

leits commented Oct 21, 2022

I need to reopen the issue because the implementation works not in an expected way. It helps to avoid flickering but also adds a very strange delay for menu updates.

@leits leits reopened this Oct 21, 2022
@kud
Copy link

kud commented Dec 12, 2022

Hey folks,

It's not only for Quick actions. It's any submenu.

Is it because you fetch and refresh every 5s the app?

@viewsourc3
Copy link

I also seem to experiment this bug, on v. 4.2.2. Refreshes every 5 seconds which makes the menu flicker and hard to select/click on text.

@leits leits closed this as completed in 0a5964c Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants