diff --git a/x-pack/plugins/spaces/public/views/management/_manage_spaces.scss b/x-pack/plugins/spaces/public/views/management/_manage_spaces.scss index f1bc69507446c..e75ec62a363cf 100644 --- a/x-pack/plugins/spaces/public/views/management/_manage_spaces.scss +++ b/x-pack/plugins/spaces/public/views/management/_manage_spaces.scss @@ -9,10 +9,3 @@ .spcGridPage { min-height: calc(100vh - 70px); } - -.spcManagePage__content { - max-width: 1280px; - margin-left: auto; - margin-right: auto; - flex-grow: 0; -} diff --git a/x-pack/plugins/spaces/public/views/management/components/secure_space_message/secure_space_message.tsx b/x-pack/plugins/spaces/public/views/management/components/secure_space_message/secure_space_message.tsx index 91d1713b37869..d7ab85c58a5d5 100644 --- a/x-pack/plugins/spaces/public/views/management/components/secure_space_message/secure_space_message.tsx +++ b/x-pack/plugins/spaces/public/views/management/components/secure_space_message/secure_space_message.tsx @@ -4,7 +4,7 @@ * you may not use this file except in compliance with the Elastic License. */ -import { EuiLink, EuiSpacer, EuiText } from '@elastic/eui'; +import { EuiLink, EuiText } from '@elastic/eui'; import React, { Fragment } from 'react'; import { UserProfile } from 'x-pack/common/user_profile'; @@ -16,7 +16,6 @@ export const SecureSpaceMessage = (props: Props) => { if (props.userProfile.hasCapability('manageSecurity')) { return ( -

Want to assign a role to a space? Go to Management and select{' '} diff --git a/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/customize_space.tsx b/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/customize_space.tsx index e70f28b335135..afdbb649b75be 100644 --- a/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/customize_space.tsx +++ b/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/customize_space.tsx @@ -12,8 +12,10 @@ import { EuiFlexItem, EuiFormRow, EuiPanel, + EuiPopover, EuiSpacer, EuiText, + EuiTextArea, } from '@elastic/eui'; import React, { ChangeEvent, Component, Fragment } from 'react'; import { isReservedSpace } from 'x-pack/plugins/spaces/common'; @@ -39,30 +41,41 @@ export class CustomizeSpace extends Component { Customize your space} description={this.getPanelDescription()} + fullWidth > - - - + + + + + + + + + + + + } + // closePopover={() => {}} + // isOpen={!!name} + > +

+ +
+ + + + - {name && ( - - - - - - - - - - - - )} + {this.props.space && isReservedSpace(this.props.space) ? null : ( @@ -77,15 +90,16 @@ export class CustomizeSpace extends Component { - @@ -126,7 +140,7 @@ export class CustomizeSpace extends Component { }); }; - public onDescriptionChange = (e: ChangeEvent) => { + public onDescriptionChange = (e: ChangeEvent) => { this.props.onChange({ ...this.props.space, description: e.target.value, diff --git a/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/customize_space_avatar.tsx b/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/customize_space_avatar.tsx index 4ad9b9e71c1c8..c0f8489d5a625 100644 --- a/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/customize_space_avatar.tsx +++ b/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/customize_space_avatar.tsx @@ -37,23 +37,24 @@ export class CustomizeSpaceAvatar extends Component { return ( - - - - - - - - - - + + + + + + ); } diff --git a/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/space_identifier.tsx b/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/space_identifier.tsx index a8fcd313d4577..191884579640b 100644 --- a/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/space_identifier.tsx +++ b/x-pack/plugins/spaces/public/views/management/edit_space/customize_space/space_identifier.tsx @@ -44,7 +44,7 @@ export class SpaceIdentifier extends Component { @@ -53,7 +53,7 @@ export class SpaceIdentifier extends Component { placeholder={ this.state.editing || !this.props.editable ? undefined - : 'The URL identifier is generated from the space name.' + : 'awesome-space' } value={id} onChange={this.onChange} @@ -74,8 +74,8 @@ export class SpaceIdentifier extends Component { return (

URL identifier {editLinkText}

); }; - public getHelpText = () => { - return (

If the identifier is engineering, the Kibana URL is
https://my-kibana.example/s/engineering/app/kibana.

); + public getHelpText = (identifier: string) => { + return (

Example: https://my-kibana.example/s/{identifier || 'awesome-space'}/app/kibana

); }; public onEditClick = () => { diff --git a/x-pack/plugins/spaces/public/views/management/edit_space/enabled_features/enabled_features.tsx b/x-pack/plugins/spaces/public/views/management/edit_space/enabled_features/enabled_features.tsx index 64d695be42222..8c268bf31346a 100644 --- a/x-pack/plugins/spaces/public/views/management/edit_space/enabled_features/enabled_features.tsx +++ b/x-pack/plugins/spaces/public/views/management/edit_space/enabled_features/enabled_features.tsx @@ -4,8 +4,8 @@ * you may not use this file except in compliance with the Elastic License. */ // @ts-ignore -import { EuiDescribedFormGroup, EuiFormRow, EuiIconTip, EuiText } from '@elastic/eui'; -import React, { Component, ReactNode } from 'react'; +import { EuiCallOut, EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiText, EuiTitle } from '@elastic/eui'; +import React, { Component, Fragment, ReactNode } from 'react'; import { Feature } from 'x-pack/common/feature'; import { Space } from 'x-pack/plugins/spaces/common/model/space'; import { CollapsiblePanel } from 'x-pack/public/components'; @@ -21,18 +21,22 @@ export class EnabledFeatures extends Component { public render() { return ( - Enable features within this space} - description={this.getDescription()} - > - + + + +

Enable features within this space

+
+ + {this.getDescription()} +
+ -
-
+ +
); } @@ -53,15 +57,8 @@ export class EnabledFeatures extends Component { ); } else if (enabledCount === 0) { details = ( - - - {' '} - (no features enabled) - + + (no features enabled) ); } else { @@ -84,13 +81,30 @@ export class EnabledFeatures extends Component { }; private getDescription = () => { + const featureCount = this.props.features.length; + const disabledCount = this.getKnownDisabledFeatures().length; + const enabledCount = featureCount - disabledCount; + return ( - -

Choose which features are enabled within this space.

-

- Note: this is not a security mechanism. -

-
+ + +

Choose which features are enabled within this space.

+

+ Note: this is not a security mechanism. +

+
+ {enabledCount === 0 && ( + + + + + )} +
); }; } diff --git a/x-pack/plugins/spaces/public/views/management/edit_space/enabled_features/feature_table.tsx b/x-pack/plugins/spaces/public/views/management/edit_space/enabled_features/feature_table.tsx index 029ee8487501e..ff8eba1641453 100644 --- a/x-pack/plugins/spaces/public/views/management/edit_space/enabled_features/feature_table.tsx +++ b/x-pack/plugins/spaces/public/views/management/edit_space/enabled_features/feature_table.tsx @@ -53,14 +53,16 @@ export class FeatureTable extends Component { render: (feature: Feature) => { return ( - - {feature.name} + +   {feature.name} ); }, }, { field: 'space', + width: '80', + align: 'right', name: 'Enabled?', render: (spaceEntry: Space, record: Record) => { const checked = !( diff --git a/x-pack/plugins/spaces/public/views/management/edit_space/manage_space_page.tsx b/x-pack/plugins/spaces/public/views/management/edit_space/manage_space_page.tsx index a265bf383ed21..fc7e23b77182d 100644 --- a/x-pack/plugins/spaces/public/views/management/edit_space/manage_space_page.tsx +++ b/x-pack/plugins/spaces/public/views/management/edit_space/manage_space_page.tsx @@ -154,7 +154,7 @@ export class ManageSpacePage extends Component { onChange={this.onSpaceChange} /> - + {this.getFormButtons()}
@@ -180,7 +180,12 @@ export class ManageSpacePage extends Component { public maybeGetSecureSpacesMessage = () => { if (this.editingExistingSpace()) { - return ; + return ( + + + + + ); } return null; };