Skip to content

Commit

Permalink
fixed; remove query batchSize option default
Browse files Browse the repository at this point in the history
Bug in MongoDB breaks result sets: SERVER-5374

Originally added to make streaming large result
sets behave nicely (otherwise huge 100000+ doc sets
may be returned when not specified).

If you are streaming large query results
and experience bad performance, you may want to
set the batchSize option: query.batchSize(1000)
Keep in mind that at this time (mongo 2.2) if
the query also uses a sort(), you will need to
add an index to that field to ensure all results
are returned.

https://jira.mongodb.org/browse/SERVER-5374
http://stackoverflow.com/questions/12643195/mongoose-limiting-query-to-1000-results-when-i-want-more-all-migrating-from-2-6
  • Loading branch information
aheckmann committed Sep 29, 2012
1 parent 4f28c52 commit 3edaa86
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions lib/query.js
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,6 @@ Query.prototype._optionsForExec = function (model) {
var options = utils.clone(this.options, { retainKeyOrder: true });
delete options.populate;

if (!('batchSize' in options))
options.batchSize = 1000;

if (!('safe' in options))
options.safe = model.schema.options.safe;

Expand Down

0 comments on commit 3edaa86

Please sign in to comment.