Remove legacy support for Xcode + libstdc++ #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hham
reviewed
Sep 28, 2016
| #endif | ||
| // various compiler targets. | ||
|
|
||
| #define STL11_ALLOWED 1 |
There was a problem hiding this comment.
STL11_ALLOWED seems unnecessary any more.
There was a problem hiding this comment.
Oh that was done out of caution given existing projects could rely on it. In platform, I removed one use of it in FileSystemUtil.cpp only recently.
Nonetheless, we probably shouldn't have users relying on it. I just checked and neither leapipc nor LeapHTTP use it, so I've gone ahead and removed here.
|
It looks good except for unnecessary STL11_ALLOWED define. |
|
Good to move on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We soon need to update autowiring to support Xcode 8. In the meantime, remove legacy unsupported configurations such as the libstdc++ build.
Removing the
_LIBCPP_VERSIONleads to implyingSTL11_ALLOWEDfor all of MSVC/clang/gcc and simplifies much of this header.I tried to leave support for older versions of gcc intact, although I suspect we're not testing those paths either.