Fix more nagging bugs #1035
Merged
Fix more nagging bugs #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gittyupagain
force-pushed
the
fix-more-issues
branch
from
e4f7346
to
61c5058
Compare
jdonald
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few remaining known issues observed in the tests when run repeatedly.
In particular, there were some timing issues with setting the thread priority that could cause the expected thread priority to be lost if set at just the wrong time.
Another issue, that was introduced in #1033, was causing calls to
CoreContext::SignalShutdownto potentially wait for aCoreThreadto shutdown, even if the wait flag was not set. The solution was to only wait toRundown(called from theCoreThread's thread) only after theCoreThread::OnStopfunction is called if we are in the midst of a shutdown.Finally, some tests were modified to clean up after themselves. Many times there were no waiting on the contexts, causing them to interfere with the next test.