Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock mutex before notifying condition variable #1031

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Lock mutex before notifying condition variable #1031

merged 1 commit into from
Oct 31, 2017

Conversation

gittyupagain
Copy link
Contributor

There was an issue in BasicThread where ShouldStop could report false when it should be true. Attempt to synchronize a little better.

@jdonald jdonald self-assigned this Oct 31, 2017
jdonald
jdonald approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@jdonald jdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BasicThreadTest cases now passing millions of runs on Windows and pathological test environments like valgrind on Linux.

@jdonald jdonald merged commit f798aa8 into master Oct 31, 2017
@jdonald jdonald deleted the fix-basic-thread branch October 31, 2017 20:08
@jdonald jdonald added this to the v1.0.5 milestone Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdonald jdonald jdonald approved these changes

Assignees

@jdonald jdonald

Labels
bug
Projects
None yet
Milestone
v1.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@gittyupagain @jdonald