Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a plugin to initialize async store for fastify #98

Merged
merged 12 commits into from
Jan 11, 2022
Merged

Conversation

Prabeshpd
Copy link
Contributor

@Prabeshpd Prabeshpd commented Jan 10, 2022

Description

Fastify request and response object is as different of express so, a new initialization plugin has been added to support fastify integration.
Read me file is also updated to include the example, output and api documentation for the fastify changes

Task Done

  • Add fastify as dev-dependency and peer dependency
  • Add new initialization function for fastify support with fastify request and response object
  • Updated .readme file to include the example for fastify
  • Updated .readme file to include outputs for the example included in read me files
  • Updated .readme file to include the documentation of initializePlugin API

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #98 (50a9be8) into master (1d0a680) will decrease coverage by 8.45%.
The diff coverage is 0.00%.

❗ Current head 50a9be8 differs from pull request most recent head 93ec5b8. Consider uploading reports for the commit 93ec5b8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   96.29%   87.83%   -8.46%     
==========================================
  Files           5        5              
  Lines         135      148      +13     
  Branches       24       25       +1     
==========================================
  Hits          130      130              
- Misses          2       15      +13     
  Partials        3        3              
Impacted Files Coverage Δ
src/index.ts 74.60% <0.00%> (-19.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97002ee...93ec5b8. Read the comment docs.

Copy link
Member

@mesaugat mesaugat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mesaugat mesaugat requested a review from prabhtz January 10, 2022 10:59
@Prabeshpd Prabeshpd changed the title Add a hook to initialize async store for fastify Add a plugin to initialize async store for fastify Jan 11, 2022
@mesaugat mesaugat merged commit 3496e1b into master Jan 11, 2022
@mesaugat mesaugat deleted the fastify-support branch January 11, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants