Remove is_enabled flag and unused methods #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 93.66% 96.29% +2.63%
==========================================
Files 5 5
Lines 142 135 -7
Branches 24 24
==========================================
- Hits 133 130 -3
+ Misses 6 2 -4
Partials 3 3
Continue to review full report at Codecov.
|
kabirbaidhya
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
Merging. But I'd mark this as a breaking change as it's a public API that the users could already be using. This could be a candidate for a minor bump - 1.2.0.
cc @cham11ng
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
isStoreEnabledvariable and it's methods that were not in use.