-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example project for koa #36
Add example project for koa #36
Conversation
@Swechhya Thanks for contributing 💯 👍. Can you update the PR description to provide some details and the changes you made? There are few comments please do resolve them and it should be mergable 🎉. |
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=======================================
Coverage 86.61% 86.61%
=======================================
Files 5 5
Lines 142 142
Branches 24 24
=======================================
Hits 123 123
Misses 15 15
Partials 4 4 Continue to review full report at Codecov.
|
@Swechhya Few more formatting and indentation fixes. You can also run Additionally, we've defined to only use single quotes in eslint. This should also be resolved once you do eslint --fix. |
@Swechhya Can you also add a link to the example in the main README under Sample Projects section here - https://github.com/leapfrogtechnology/async-store#sample-projects? Everything else looks good. Thanks. |
Add a new example project for koa.
Resolves #17