Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example project for koa #36

Merged
merged 6 commits into from
Oct 26, 2019

Conversation

Swechhya
Copy link
Member

@Swechhya Swechhya commented Oct 26, 2019

Add a new example project for koa.

Resolves #17

@kabirbaidhya
Copy link
Contributor

@Swechhya Thanks for contributing 💯 👍.

Can you update the PR description to provide some details and the changes you made? There are few comments please do resolve them and it should be mergable 🎉.

@codecov-io
Copy link

codecov-io commented Oct 26, 2019

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   86.61%   86.61%           
=======================================
  Files           5        5           
  Lines         142      142           
  Branches       24       24           
=======================================
  Hits          123      123           
  Misses         15       15           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 032cb25...d9e62a2. Read the comment docs.

@kabirbaidhya
Copy link
Contributor

@Swechhya Few more formatting and indentation fixes. You can also run eslint --fix which will resolve most of these issues.

Additionally, we've defined to only use single quotes in eslint. This should also be resolved once you do eslint --fix.

@kabirbaidhya
Copy link
Contributor

@Swechhya Can you also add a link to the example in the main README under Sample Projects section here - https://github.com/leapfrogtechnology/async-store#sample-projects?

Everything else looks good. Thanks.

@kabirbaidhya kabirbaidhya merged commit bbb37d3 into leapfrogtechnology:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an example project for koa js
3 participants