Remove unreachable code #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getStore() checks for active domain before updating the store.
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 84.89% 86.13% +1.23%
==========================================
Files 5 5
Lines 139 137 -2
Branches 23 22 -1
==========================================
Hits 118 118
+ Misses 16 15 -1
+ Partials 5 4 -1
Continue to review full report at Codecov.
|
kabirbaidhya
approved these changes
Oct 6, 2019
There was a problem hiding this comment.
Indeed. Looks like this case was already covered in getStore().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through the code coverage and saw that
updateStorewas checking whether active domain existed or not. However,setmethod already does this when callinggetStore(). This piece of code is unreachable.