Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests for edge cases #33

Merged
merged 10 commits into from
Oct 6, 2019
Merged

Add missing tests for edge cases #33

merged 10 commits into from
Oct 6, 2019

Conversation

kabirbaidhya
Copy link
Contributor

Add missing tests for edge cases for better coverage.

@codecov-io
Copy link

codecov-io commented Oct 5, 2019

Codecov Report

Merging #33 into master will increase coverage by 13.66%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #33       +/-   ##
===========================================
+ Coverage   71.22%   84.89%   +13.66%     
===========================================
  Files           5        5               
  Lines         139      139               
  Branches       23       23               
===========================================
+ Hits           99      118       +19     
+ Misses         32       16       -16     
+ Partials        8        5        -3
Impacted Files Coverage Δ
src/index.ts 70.9% <0%> (+7.27%) ⬆️
src/impl/domain.ts 93.5% <0%> (+19.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8af05...9d2d2a3. Read the comment docs.

@mesaugat mesaugat changed the title Add missing tests for edge cases for better coverage Add missing tests for edge cases Oct 5, 2019
Copy link
Member

@mesaugat mesaugat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@mesaugat mesaugat merged commit cefc3e7 into master Oct 6, 2019
@mesaugat mesaugat deleted the missing-tests branch October 6, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants