Add new accessor function getAll() #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 70.76% 71.22% +0.45%
==========================================
Files 5 5
Lines 130 139 +9
Branches 21 23 +2
==========================================
+ Hits 92 99 +7
- Misses 31 32 +1
- Partials 7 8 +1
Continue to review full report at Codecov.
|
evless
force-pushed
the
feat/add-getAll-method
branch
from
2de8b76 to
c152a21
Compare
mesaugat
approved these changes
Oct 4, 2019
cham11ng
approved these changes
Oct 5, 2019
kabirbaidhya
approved these changes
Oct 5, 2019
kabirbaidhya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #27
Hi! I added getAll method and test with this case.