We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async-store/src/index.ts
Line 166 in 3a4f124
async-store/src/impl/domain.ts
Lines 194 to 213 in 3a4f124
@cham11ng We either need to make store.getId() fail-safe like find() or we'll need to create a new fail-safe version eg: findId().
store.getId()
find()
findId()
cc @mesaugat
The text was updated successfully, but these errors were encountered:
If the domain is not found, it returns undefined. It's already safe. But we need to test of getId for initialized and not initialized case.
domain
undefined
getId
Sorry, something went wrong.
Yes, we need a couple of tests to make sure this is fail-safe.
Added some test cases for getId()
#18
cham11ng
Successfully merging a pull request may close this issue.
async-store/src/index.ts
Line 166 in 3a4f124
async-store/src/impl/domain.ts
Lines 194 to 213 in 3a4f124
@cham11ng We either need to make
store.getId()
fail-safe likefind()
or we'll need to create a new fail-safe version eg:findId()
.cc @mesaugat
The text was updated successfully, but these errors were encountered: