GCC doesn't allow members in anonymous aggregate: struct Matrix4x4

[zwillikon]

I struggle at compiling PicoGK with GCC, since the GNU compiler doesn't allow members with constructors in anonymous aggregates

I'm using (Linux) gcc 14.2.1, but older versions are also afflicted

struct Matrix4x4
{
    union
    {
        struct
        {
            Vector4 vec1;
            Vector4 vec2;
            Vector4 vec3;
            Vector4 vec4;
        };
        
        float   m[16];
    };

[ 94%] Building CXX object CMakeFiles/picogk.dir/Source/PicoGKGLViewer.cpp.o
In file included from ./PicoGKRuntime/Source/PicoGKGLViewer.h:39,
                 from ./PicoGKRuntime/Source/PicoGKGLViewer.cpp:37:
./PicoGKRuntime/Source/PicoGKTypes.h:278:21: error: member 'PicoGK::Vector4 PicoGK::Matrix4x4::<unnamed union>::<unnamed struct>::vec1' with constructor not allowed in anonymous aggregate
  278 |             Vector4 vec1;
      |                     ^~~~
./PicoGKRuntime/Source/PicoGKTypes.h:279:21: error: member 'PicoGK::Vector4 PicoGK::Matrix4x4::<unnamed union>::<unnamed struct>::vec2' with constructor not allowed in anonymous aggregate
  279 |             Vector4 vec2;
      |                     ^~~~
./PicoGKRuntime/Source/PicoGKTypes.h:280:21: error: member 'PicoGK::Vector4 PicoGK::Matrix4x4::<unnamed union>::<unnamed struct>::vec3' with constructor not allowed in anonymous aggregate
  280 |             Vector4 vec3;
      |                     ^~~~
./PicoGKRuntime/Source/PicoGKTypes.h:281:21: error: member 'PicoGK::Vector4 PicoGK::Matrix4x4::<unnamed union>::<unnamed struct>::vec4' with constructor not allowed in anonymous aggregate
  281 |             Vector4 vec4;
      |                     ^~~~
make[2]: *** [CMakeFiles/picogk.dir/build.make:90: CMakeFiles/picogk.dir/Source/PicoGKGLViewer.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:203: CMakeFiles/picogk.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Just inventing names wasn't sufficient:

struct Matrix4x4
{
    union bar
    {
        struct foo
        {
            Vector4 vec1;
            Vector4 vec2;
            Vector4 vec3;
            Vector4 vec4;
        };
        
        float   m[16];
    };

leads to:

./Source/PicoGKTypes.h: In constructor 'PicoGK::Matrix4x4::Matrix4x4()':
./Source/PicoGKTypes.h:288:7: error: class 'PicoGK::Matrix4x4' does not have any field named 'vec1'
  288 |     : vec1(Vector4(1.0f, 0.0f, 0.0f, 0.0f)),
[..]

[soigniert]

Hello zwillikon,
I can report, that I had the same issue some months ago, when my Windows PC was not available for me.
I spent a whole weekend in order to compile the library and gave up (PicoGK 1.3, Ubuntu 22.04.4 LTS)
Multiple versions of cmake with different gcc and clang (cmake 3.27.4, 3.29.2., 3.30.3 are the ones I can recall from the logs, I even set up a clean ubuntu, since I found that anaconda folder was always used to look for clang++ even when deleted, search path changed, aso...). In general I can say I progressed best with clang instead gcc. With clang I could at least compile runtime (1.1) from CorrieVS.
The problem with the specific code snipped I also ran into first place. It could be resolved somehow by writing it in a different form I cannot recall currently maybe like below, but I remember it only proceeded a bit with the compiling while running into another error. My latest explanation to myself was that the available cmake is just outdated. I would recommend to you, to ask at the fork of CorrieVS for help, since afaik leap71 uses macOS only and it's a concession to be provided for a windows runtime too. I can understand, since its not so easy with linux compatibility. Nonetheless I always hope for someone to keep the runtime available for linux users updated, since they lack in powerful design and CAx tools.
Best

struct Matrix4x4
{
    union
    {
        struct
        {
            Vector4 vectors[4];
        };
        
        float   m[16];
    } matrix;
        
    Matrix4x4()
    : matrix({{Vector4(1.0f, 0.0f, 0.0f, 0.0f),
              Vector4(0.0f, 1.0f, 0.0f, 0.0f),
              Vector4(0.0f, 0.0f, 1.0f, 0.0f),
              Vector4(0.0f, 0.0f, 0.0f, 1.0f)}})
    {

    }

[zwillikon]

Hi T Soignier,

thanks for your help. I wish'd I'd knew any C++ (just C)!

With old versions of clang I tend to get myriad errors against GCC's libstdc++ my because it is getting ratcheted up by Mr. Wakely

Your approach looks promising. Now only m is missing:

./Source/PicoGKTypes.h: In member function 'void PicoGK::Matrix4x4::operator*=(const PicoGK::Matrix4x4&)':
./Source/PicoGKTypes.h:304:28: error: 'm' was not declared in this scope
  304 |                     sum += m[row + i * 4] * other.m[col * 4 + i];
      |                            ^
./Source/PicoGKTypes.h:304:51: error: 'const struct PicoGK::Matrix4x4' has no member named 'm'
  304 |                     sum += m[row + i * 4] * other.m[col * 4 + i];
      |                                                   ^
./Source/PicoGKTypes.h:306:24: error: 'struct PicoGK::Matrix4x4' has no member named 'm'
  306 |                 result.m[col * 4 + row] = sum;
      |                        ^