Skip to content
This repository was archived by the owner on Oct 25, 2023. It is now read-only.

Diamond version conflict not detected/reported #110

Closed
lovettchris opened this issue Aug 2, 2022 · 2 comments
Closed

Diamond version conflict not detected/reported #110

lovettchris opened this issue Aug 2, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
v4.0.0

Comments

@lovettchris
Copy link

lovettchris commented Aug 2, 2022 •
edited
Loading

diamond.zip

image

This builds and runs, but I have no idea which version of the csvparser it ended up using.
@tydeu
Copy link
Member

tydeu commented Aug 2, 2022 •
edited
Loading

See #70, in the next milestone there will be logging showing what version has been chosen (on a lake update). Regardless of version, Lake always does a best effort approach and it is up to the user to resolve conflicts (by inspecting / editing lean_packages/manifest.json).

@tydeu tydeu added the enhancement New feature or request label Aug 8, 2022
@tydeu
Copy link
Member

tydeu commented Aug 8, 2022

As this should be solved in the current v4.0.0, I am closing this issue.

@tydeu tydeu closed this as completed Aug 8, 2022
@tydeu tydeu added this to the v4.0.0 milestone Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@tydeu @lovettchris