Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc_max_rate bigger than rc_min_rate #135

Open
muniategui opened this issue Aug 16, 2024 · 2 comments
Open

rc_max_rate bigger than rc_min_rate #135

muniategui opened this issue Aug 16, 2024 · 2 comments

Comments

@muniategui
Copy link

In trascoding example there are these lines:
video_avcc->rc_max_rate = 2 * 1000 * 1000;
video_avcc->rc_min_rate = 2.5 * 1000 * 1000;

Which are wrong since the max rate is less than the minimal rate.

@leandromoreira
Copy link
Owner

thanks for pointing out

@muniategui
Copy link
Author

Well in fact I would like to mention that rc_min_rate is not used by libx264.c nor libx265.c in FFMPEG source code so probably this value should be removed since it does nothing.

https://github.com/libav/libav/blob/master/libavcodec/libx264.c
rc_max_rate is used to set vbv_max_bitrat in libx264 internal

rc_min_rate seems to only be used in nvenc codec: https://github.com/libav/libav/blob/c4642788e83b0858bca449f9b6e71ddb015dfa5d/libavcodec/nvenc.c#L1016

(and 2 more random codecs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants