Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default analytics to opt out #2483

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Change default analytics to opt out #2483

wants to merge 8 commits into from
+157 −24

Conversation

pdenert
Copy link
Collaborator

@pdenert pdenert commented Jan 10, 2025 •
edited
Loading

Add option to set PATROL_ANALYTICS_ENABLED environment.
Now analytics:

  1. If PATROL_ANALYTICS_ENABLED is setup - use this variable value
  2. If PATROL_ANALYTICS_ENABLED is not setup, but file $Home.config\patrol_cli\analytics.json exist - take value from this file
  3. Enable analytics by default

Should also fix #2475

@docs-page docs.page
Copy link

docs-page bot commented Jan 10, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/leancodepl/patrol~2483

Documentation is deployed and generated using docs.page.

@github-actions github-actions bot added docs Concerns doc comments, READMEs, or docs package: patrol_cli Related to the patrol_cli package labels Jan 10, 2025
@pdenert pdenert requested a review from piotruela January 14, 2025 15:13
@pdenert pdenert requested a review from piotruela January 14, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotruela piotruela piotruela approved these changes

@mateuszwojtczak mateuszwojtczak Awaiting requested review from mateuszwojtczak mateuszwojtczak is a code owner

Assignees
No one assigned
Labels
docs Concerns doc comments, READMEs, or docs package: patrol_cli Related to the patrol_cli package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null check exception when running patrol doctor
2 participants
@pdenert @piotruela