Skip to content

Commit dc6839f

Browse files
akpm00hnaz
authored andcommitted
fs-elf-drop-map_fixed-usage-from-elf_map-checkpatch-fixes
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")' torvalds#8: (before eab0953 ("binfmt_elf: use ELF_ET_DYN_BASE only for PIE")) ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")' torvalds#15: further from the stack (eab0953 and later by c715b72 ("mm: ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")' torvalds#17: stack consumption early during execve fully stopped by da029c1 WARNING: 'segement' may be misspelled - perhaps 'segment'? torvalds#64: FILE: arch/metag/kernel/process.c:421: + pr_info("%d (%s): Uhuuh, elf segement at %p requested but the memory is mapped already\n", ERROR: "(foo*)" should be "(foo *)" torvalds#65: FILE: arch/metag/kernel/process.c:422: + task_pid_nr(current), tsk->comm, (void*)addr); WARNING: 'segement' may be misspelled - perhaps 'segment'? torvalds#78: FILE: fs/binfmt_elf.c:381: + pr_info("%d (%s): Uhuuh, elf segement at %p requested but the memory is mapped already\n", WARNING: line over 80 characters torvalds#79: FILE: fs/binfmt_elf.c:382: + task_pid_nr(current), current->comm, (void*)addr); ERROR: "(foo*)" should be "(foo *)" torvalds#79: FILE: fs/binfmt_elf.c:382: + task_pid_nr(current), current->comm, (void*)addr); total: 5 errors, 3 warnings, 60 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/fs-elf-drop-map_fixed-usage-from-elf_map.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Michal Hocko <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 0ecdc10 commit dc6839f

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

Diff for: arch/metag/kernel/process.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -418,8 +418,8 @@ unsigned long __metag_elf_map(struct file *filep, unsigned long addr,
418418
map_addr = vm_mmap(filep, addr, size, prot, type, off);
419419

420420
if ((type & MAP_FIXED_SAFE) && BAD_ADDR(map_addr))
421-
pr_info("%d (%s): Uhuuh, elf segement at %p requested but the memory is mapped already\n",
422-
task_pid_nr(current), tsk->comm, (void*)addr);
421+
pr_info("%d (%s): Uhuuh, elf segment at %p requested but the memory is mapped already\n",
422+
task_pid_nr(current), tsk->comm, (void *)addr);
423423

424424
if (!BAD_ADDR(map_addr) && tcm_tag != TCM_INVALID_TAG) {
425425
struct tcm_allocation *tcm;

Diff for: fs/binfmt_elf.c

+3-2
Original file line numberDiff line numberDiff line change
@@ -378,8 +378,9 @@ static unsigned long elf_map(struct file *filep, unsigned long addr,
378378
map_addr = vm_mmap(filep, addr, size, prot, type, off);
379379

380380
if ((type & MAP_FIXED_SAFE) && BAD_ADDR(map_addr))
381-
pr_info("%d (%s): Uhuuh, elf segement at %p requested but the memory is mapped already\n",
382-
task_pid_nr(current), current->comm, (void*)addr);
381+
pr_info("%d (%s): Uhuuh, elf segment at %p requested but the memory is mapped already\n",
382+
task_pid_nr(current), current->comm,
383+
(void *)addr);
383384

384385
return(map_addr);
385386
}

0 commit comments

Comments
 (0)