Disabling recipes not "sticking" on upgrade

[Talyda]

Is there an existing issue for this?

• I have searched the existing issues.

Are you using the latest MineColonies Version?

• I am running the latest beta/release version of MineColonies for my Minecraft version.
  I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

• I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

• Single Player
• Multi Player

Minecraft Version

1.20

MineColonies Version

.700

Structurize Version

.760

Related Mods and their Versions

No response

Current Behavior

On raid server, I noticed when I upgraded my enchanter, the recipe I had disabled (the one using ancient tomes) enabled itself again as soon as I upgraded. I am about 90% sure it happened with the smelter also (I had turned off all ores, so that I had plenty when I needed them for research)
Haven't noticed if it happens in other buildings, but I know I have some more that have disabled recipes, so will see when I upgrade those

Expected Behavior

Preferences to keep

Reproduction Steps

Build enchanter, disable recipe, upgrade

Logs

I don't have one from the time

Anything else?

No response

Footer

---

Viewers

• Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
• Add a comment if you have any insights or background information that isn't already part of the conversation.

[Talyda]

Just to confirm, have upgraded enchanting tower again, and it is now asking for ancient tomes again and recipe is re-enabled

[uecasm]

This is currently behaving as intended. The trick is that the recipe you disabled and the recipe that was enabled again after upgrade are actually different recipes. If you look in JEI, you'll see that there are separate listings for the enchanter at each level, because they have different stuff. What happens is that after the upgrade, the old recipe is deleted (and so is no longer disabled) and a new recipe is added (and is enabled by default, like all recipes).

This will happen for any such single-level recipe, or in cases where you happen to upgrade past a recipe change point (e.g. L3 baker switching their bread recipe). For other upgrades it should keep the setting, since the recipe didn't change.

[Shadizar]

Is there no way to improve the behavior? I too, never want my precious tomes used by the enchanter, and risking losing some on upgrade is unfortunate (some may be in the warehouse from faid activity)
The tome-consuming recipes are ones I never, ever want active

[Thodor12]

Could be doable, in another PR I just introduced a loot condition for building level. So we could theoretically wrap the entire enchanter loot table into 1 file and let the building level condition decide which entries are up for taking.
That would also void the need for requiring 5 different tome recipes each with it's own loot table.

Building level condition: https://github.com/ldtteam/minecolonies/pull/10343/files#diff-60500f26b761516ddd3287a359f99cb4072f511062079956ddf4526740a5bca6

[uecasm]

Having the separate loot tables is better than using a loot condition, at least for JEI display purposes. So no, don't do that.

[Talyda]

This is currently behaving as intended. The trick is that the recipe you disabled and the recipe that was enabled again after upgrade are actually different recipes.
I had started to suspect that last night before I went to bed when the newer colony teleport scrolls wouldn't stack with the old ones (or is that unrelated?)

Could that recipe, using tomes, possibly default to "off" then? I'm not sure anyone gets so many tomes that it would be a terrible inconvenience and gum up their colony

[uecasm]

That's one of the core features of enchanters, and there isn't any other use for tomes other than refunding research, so I'm not sure why you'd need to stockpile them.

[Talyda]

I don't need to stockpile them, but they drop so rarely that I want them for research before the enchanter can use them

[Talyda]

Even without not being able to get them atm cos of raid server, I don't want enchanter wasting them before level 5 building, And if I turn a recipe off, I expect it to stay off.
I haven't upgraded smelter again yet to check, but I am pretty sure ores got turned back on on upgrade too (will hopefully upgrade that today)

[Talyda]

Was wrong on the smeltery BTW - I think I got confused between the two different lists =)