Don't suggest test context in test cleanup functions

testdata/src/contextbackground/basic/basic_test.go

@@ -7,6 +7,7 @@ import (
 	"runtime"
 	"strings"
 	"testing"
+	"time"
 )
 
 func bar() func(t *testing.T) {
@@ -209,3 +210,22 @@ func Test_SwitchStmt_Tag(t *testing.T) {
 func foobar() {
 	context.Background()
 }
+
+func Test_Ignores_Inside_Cleanup(t *testing.T) {
+	fakeSlowClose := func(ctx context.Context) error {
+		select {
+		case <-ctx.Done():
+			return ctx.Err()
+		case <-time.After(time.Second):
+			return nil
+		}
+	}
+	t.Cleanup(func() {
+		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Millisecond)
+		defer cancel()
+		err := fakeSlowClose(ctx)
+		if err != nil {
+			t.Errorf("fakeSlowClose timed out on closing during cleanup: %v", err)
+		}
+	})
+}

testdata/src/contextbackground/basic/basic_test.go.golden

@@ -7,6 +7,7 @@ import (
 	"runtime"
 	"strings"
 	"testing"
+	"time"
 )
 
 func bar() func(t *testing.T) {
@@ -209,3 +210,22 @@ func Test_SwitchStmt_Tag(t *testing.T) {
 func foobar() {
 	context.Background()
 }
+
+func Test_Ignores_Inside_Cleanup(t *testing.T) {
+	fakeSlowClose := func(ctx context.Context) error {
+		select {
+		case <-ctx.Done():
+			return ctx.Err()
+		case <-time.After(time.Second):
+			return nil
+		}
+	}
+	t.Cleanup(func() {
+		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Millisecond)
+		defer cancel()
+		err := fakeSlowClose(ctx)
+		if err != nil {
+			t.Errorf("fakeSlowClose timed out on closing during cleanup: %v", err)
+		}
+	})
+}

usetesting.go

@@ -146,6 +146,15 @@ func (a *analyzer) checkFunc(pass *analysis.Pass, ft *ast.FuncType, block *ast.B
 			return !a.reportIdent(pass, v, fnInfo, geGo124)
 
 		case *ast.CallExpr:
+			// Don't check inside t.Cleanup() calls
+			if selx, ok := v.Fun.(*ast.SelectorExpr); ok {
+				if idt, ok := selx.X.(*ast.Ident); ok {
+					if selx.Sel.Name == "Cleanup" && idt.Name == fnInfo.ArgName {
+						return false
+					}
+				}
+			}
+
 			return !a.reportCallExpr(pass, v, fnInfo)
 		}