Skip to content

fix: disable context-related checks by default #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

fix: disable context-related checks by default #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ linters:

# Enable/disable `context.Background()` detections.
# Disabled if Go < 1.24.
# Default: true
context-background: false
# Default: false
context-background: true

# Enable/disable `context.TODO()` detections.
# Disabled if Go < 1.24.
# Default: true
context-todo: false
# Default: false
context-todo: true
```

### As a CLI
Expand Down
4 changes: 2 additions & 2 deletions usetesting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ func NewAnalyzer() *analysis.Analyzer {
Run: l.run,
}

a.Flags.BoolVar(&l.contextBackground, "contextbackground", true, "Enable/disable context.Background() detections")
a.Flags.BoolVar(&l.contextTodo, "contexttodo", true, "Enable/disable context.TODO() detections")
a.Flags.BoolVar(&l.contextBackground, "contextbackground", false, "Enable/disable context.Background() detections")
a.Flags.BoolVar(&l.contextTodo, "contexttodo", false, "Enable/disable context.TODO() detections")
a.Flags.BoolVar(&l.osChdir, "oschdir", true, "Enable/disable os.Chdir() detections")
a.Flags.BoolVar(&l.osMkdirTemp, "osmkdirtemp", true, "Enable/disable os.MkdirTemp() detections")
a.Flags.BoolVar(&l.osSetenv, "ossetenv", false, "Enable/disable os.Setenv() detections")
Expand Down
16 changes: 8 additions & 8 deletions usetesting_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ func TestAnalyzer(t *testing.T) {
{dir: "oschdir/nottestfiles"},
{dir: "oschdir/disable", options: map[string]string{"oschdir": "false"}},

{dir: "contextbackground/basic"},
{dir: "contextbackground/dot"},
{dir: "contextbackground/nottestfiles"},
{dir: "contextbackground/disable", options: map[string]string{"contextbackground": "false"}},
{dir: "contextbackground/basic", options: map[string]string{"contextbackground": "true"}},
{dir: "contextbackground/dot", options: map[string]string{"contextbackground": "true"}},
{dir: "contextbackground/nottestfiles", options: map[string]string{"contextbackground": "true"}},
{dir: "contextbackground/disable"},

{dir: "contexttodo/basic"},
{dir: "contexttodo/dot"},
{dir: "contexttodo/nottestfiles"},
{dir: "contexttodo/disable", options: map[string]string{"contexttodo": "false"}},
{dir: "contexttodo/basic", options: map[string]string{"contexttodo": "true"}},
{dir: "contexttodo/dot", options: map[string]string{"contexttodo": "true"}},
{dir: "contexttodo/nottestfiles", options: map[string]string{"contexttodo": "true"}},
{dir: "contexttodo/disable"},

{dir: "osmkdirtemp/basic"},
{dir: "osmkdirtemp/dot"},
Expand Down