From 2993fc0616ca8c5613150a291e0fe8cab54cd140 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 10 Jun 2025 17:09:11 +0200 Subject: [PATCH] fix: disable context-related checks by default --- readme.md | 8 ++++---- usetesting.go | 4 ++-- usetesting_test.go | 16 ++++++++-------- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/readme.md b/readme.md index 0da8c8d..c4dd3da 100644 --- a/readme.md +++ b/readme.md @@ -40,13 +40,13 @@ linters: # Enable/disable `context.Background()` detections. # Disabled if Go < 1.24. - # Default: true - context-background: false + # Default: false + context-background: true # Enable/disable `context.TODO()` detections. # Disabled if Go < 1.24. - # Default: true - context-todo: false + # Default: false + context-todo: true ``` ### As a CLI diff --git a/usetesting.go b/usetesting.go index 6ff18f9..ecd113b 100644 --- a/usetesting.go +++ b/usetesting.go @@ -76,8 +76,8 @@ func NewAnalyzer() *analysis.Analyzer { Run: l.run, } - a.Flags.BoolVar(&l.contextBackground, "contextbackground", true, "Enable/disable context.Background() detections") - a.Flags.BoolVar(&l.contextTodo, "contexttodo", true, "Enable/disable context.TODO() detections") + a.Flags.BoolVar(&l.contextBackground, "contextbackground", false, "Enable/disable context.Background() detections") + a.Flags.BoolVar(&l.contextTodo, "contexttodo", false, "Enable/disable context.TODO() detections") a.Flags.BoolVar(&l.osChdir, "oschdir", true, "Enable/disable os.Chdir() detections") a.Flags.BoolVar(&l.osMkdirTemp, "osmkdirtemp", true, "Enable/disable os.MkdirTemp() detections") a.Flags.BoolVar(&l.osSetenv, "ossetenv", false, "Enable/disable os.Setenv() detections") diff --git a/usetesting_test.go b/usetesting_test.go index 2194bad..7066333 100644 --- a/usetesting_test.go +++ b/usetesting_test.go @@ -16,15 +16,15 @@ func TestAnalyzer(t *testing.T) { {dir: "oschdir/nottestfiles"}, {dir: "oschdir/disable", options: map[string]string{"oschdir": "false"}}, - {dir: "contextbackground/basic"}, - {dir: "contextbackground/dot"}, - {dir: "contextbackground/nottestfiles"}, - {dir: "contextbackground/disable", options: map[string]string{"contextbackground": "false"}}, + {dir: "contextbackground/basic", options: map[string]string{"contextbackground": "true"}}, + {dir: "contextbackground/dot", options: map[string]string{"contextbackground": "true"}}, + {dir: "contextbackground/nottestfiles", options: map[string]string{"contextbackground": "true"}}, + {dir: "contextbackground/disable"}, - {dir: "contexttodo/basic"}, - {dir: "contexttodo/dot"}, - {dir: "contexttodo/nottestfiles"}, - {dir: "contexttodo/disable", options: map[string]string{"contexttodo": "false"}}, + {dir: "contexttodo/basic", options: map[string]string{"contexttodo": "true"}}, + {dir: "contexttodo/dot", options: map[string]string{"contexttodo": "true"}}, + {dir: "contexttodo/nottestfiles", options: map[string]string{"contexttodo": "true"}}, + {dir: "contexttodo/disable"}, {dir: "osmkdirtemp/basic"}, {dir: "osmkdirtemp/dot"},