[REQUEST] window overview with images/icons

[ildar]

Before opening a feature request

• I checked the next branch to see if the feature has already been implemented
• I searched existing reports to see if it is already requested.

What is the user problem or growth opportunity you want to see solved?

Window overview show only XWayland windows' icons

rofi -show drun -show-icons

How do you know that this problem exists today? Why is this important?

rofi -show drun -show-icons

Window overview should show window images or icons.

Who will benefit from it?

Wayland users

Rofi version (rofi -v)

Version: 1.7.5+wayland2

Configuration

none

Additional information

any smart hint for this?
Compositor: Hyprland.

[lbonn]

Just to clarify, you are talking about "window overview" but your description mentions a drun invocation. Did you mean rofi -show window -show-icons?

On sway, I have just tried it and it shows the firefox icon just fine even though it is a native wayland window.

Maybe it's an issue with hyprland not filling in the app_id in this case?

See the code here

rofi/source/modes/wayland-window.c

Line 597 in 36621af

/**

[ildar]

Hi! thanks for answering.

On Wed, Dec 6, 2023 at 5:28 PM lbonn wrote: Just to clarify, you are talking about "window overview" but your description mentions a drun invocation. Did you mean rofi -show window -show-icons?

true.

On sway, I have just tried it and it shows the firefox icon just fine even though it is a native wayland window. Maybe it's an issue with hyprland not filling in the app_id in this case? See the code here https://github.com/lbonn/rofi/blob/36621af0e49e1272fcafb161e1dbf0c1345b394f/source/modes/wayland-window.c#L597

not really. Hyprland seems to handle the app_id right though I'm no Wayland expert at all. Just see the screenshot below and this: hyprwm/Hyprland@2cd2f8b

[ildar]

[Seme4eg]

To me it seems like a problem with -show-icons flag, because i have a script for a long time, that was working just fine and was doing following:

• get a path to a wallpaper and print it with its icon path so rofi was displaying it

  find -L "$wp_dir" -type f -printf "%P\n" |
    while read -r wp; do
      printf '%s\x00icon\x1f%s/%s\n' "$wp" "$wp_dir" "$wp"
    done

• pipe those strings to rofi -dmenu -i -show-icons -select "${wallpaper#"$wp_dir/"}" -theme-str {custom theme}"

full script is here

and now its broken and instead of small thumbnails shows this, so i guess its stopped evaluating the icon paths properly

[lbonn]

@Seme4eg Right now I can only test on x11 but this works and shows some headphones icon on the latest dev commit:

printf 'test\x00icon\x1f%s\n' /usr/share/icons/Adwaita/32x32/devices/audio-headphones.png | rofi -dmenu -show-icons

Your screenshot looks a bit strange to me because it shows literal \x00 whereas actual bytes should be sent and rofi does not display them in an escaped way.

My guess is that it's a shell thing. I see that your script starts with #!/bin/sh which would be dash on ubuntu which seems to have a different printf:

$ dash -c 'printf "\x30\n"'
\x30

Try with bash

[Seme4eg]

And you are absolutely right, sir, very much my bad. Couldn't think that it would affect this.