Use sse2neon.h shim for aarch64 support #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove -m64 CFLAG because it is x86_64 specific Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
|
Also added Github Actions based CI config. |
This was referenced Aug 30, 2022
martin-g
force-pushed
the
linux-arm64-support
branch
from
50a1ed1 to
bdd6214
Compare
|
Any chance this PR could be reviewed and eventually merged ? |
emiliofernandes
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Awesome work, @martin-g !
Your PR helped me build GraphMap2 on Linux aarch64!
|
How about aarch64 for MacOS? I have the following error: src/ksw2/ksw2_ll_sse.cc:4:10: fatal error: emmintrin.h: No such file or directory I use brew installed GCC/G++. Thanks, Jianshu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sse2neon.h is taken from https://github.com/DLTcollab/sse2neon/releases/tag/v1.5.1.
Remove -m64 CFLAG because it is x86_64 specific and it is GCC's default for 64-bit systems anyway.
Fixes #21 and #22